documentation: add doc for SMDDP collectives #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mufaddal Rohawala <[email protected]>
Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: Kalyani Nikure <[email protected]>
…aws#3438) Co-authored-by: Keshav Chandak <[email protected]>
Co-authored-by: Navin Soni <[email protected]>
* Add DXB region * Remove change from neuron * Adding DXB to TF 2.1.0 and 2.1.1
Co-authored-by: Brock Wade <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>
…timator starting 1.12 (aws#3500) Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Malav Shastri <[email protected]>
Co-authored-by: Brock Wade <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>
Co-authored-by: Dewen Qi <[email protected]>
* Set to true by default * Update pt ddp supported versions Add validation for instance type, fw and py versions. Clean up logs and comments Add integ test for ACCL disabled Fix integ test params Fix formatting errors in tests Update logic to set accl_enabled to none for default on cases
mchoi8739
force-pushed
the
smddp-collectives-doc
branch
from
1a48cb5 to
cfddea6
Compare
mchoi8739
force-pushed
the
smddp-collectives-doc
branch
from
cfddea6 to
83d754e
Compare
vishwakaria
reviewed
Dec 12, 2022
Comment on lines
+342
to
+344
| "communication_options": { # Optional. This is set to auto by default. | ||
| "backend": "auto" | ||
| } |
There was a problem hiding this comment.
Can we make these lines bold?
There was a problem hiding this comment.
unfortunately Sphinx code block doesn't support adding styles
There was a problem hiding this comment.
In the code block every character is recognizes as straight code syntax, so it would show the element for bold style, instead of the bold style applied to the lines.
There was a problem hiding this comment.
ref discussion in stackoverflow: https://stackoverflow.com/questions/26366552/bold-code-in-rst
Comment on lines
+199
to
+201
| "communication_options": { | ||
| "backend": "auto", # backend is set to auto by default | ||
| } |
vishwakaria
approved these changes
Dec 12, 2022
vishwakaria
force-pushed
the
smddp-coll
branch
from
558e3f8 to
094ee86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
documentation for SMDDP collectives + small fix for compiler_config (wrong indentation)
Testing done:
local sphinx build completed
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.